Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.05] invidious sig helper #344967

Merged

Conversation

lelgenio
Copy link
Contributor

@lelgenio lelgenio commented Sep 27, 2024

Description of changes

My invidious instance recently became unusable, the only solution I found was enabling invidious-sig-helper, which is currently only available in unstable.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@lelgenio
Copy link
Contributor Author

Result of nixpkgs-review pr 344967 run on x86_64-linux 1

1 package blacklisted:
  • nixos-install-tools
1 package built:
  • inv-sig-helper

@GaetanLepage
Copy link
Contributor

Have you tested this patch on your system ?

@lelgenio
Copy link
Contributor Author

Have you tested this patch on your system ?

Yes

the only solution I found was enabling invidious-sig-helper, which is currently only available in unstable.

By that I mean "The only thing I tried and it worked".

My VPS is running 24.05, I tested this patch via an equivalent to:

nixos-rebuild switch \
  --flake .#my-vps \
  --target-host my-vps \
  --override-input nixpkgs github:lelgenio/nixpkgs/backport-invidious-sig-helper

@GaetanLepage
Copy link
Contributor

Cool, thanks :)

@GaetanLepage GaetanLepage merged commit ced0da1 into NixOS:release-24.05 Sep 28, 2024
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants