python312Packages.chromadb: 0.5.7 -> 0.5.11 #345372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 4 packages marked as broken and skipped:
6 packages failed to build:
8 packages built:
|
|
Looks like |
|
I'll push out the needed langchain updates this afternoon. You also have a flaky test at chromadb/test/proto/test_utils.py::test_retry_interceptor |
5 tasks
|
Uff, more failing tests |
Well, nuts. Uff, as you say. Fixing the async test made this work yesterday but it's failing again today. (It also worked in the nixpkgs-review last night). I will need to dig more deeply. |
|
Turns out that the langchain repo's integration tests fail the same way outside nixos: # Assert that the updated document is returned by the search
assert output == [Document(page_content=updated_content, metadata={"page": "0"})]
> assert new_embedding == embedding.embed_documents([updated_content])[0]
E ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
tests/integration_tests/test_vectorstores.py:257: ValueError
======================================================================= warnings summary ========================================================================
tests/integration_tests/test_vectorstores.py::test_chroma_async
/Users/seclark/development/langchain/.devenv/state/venv/lib/python3.11/site-packages/_pytest/python.py:148: PytestUnhandledCoroutineWarning: async def functions are not natively supported and have been skipped.
You need to install a suitable plugin for your async framework, for example:
- anyio
- pytest-asyncio
- pytest-tornasync
- pytest-trio
- pytest-twisted
warnings.warn(PytestUnhandledCoroutineWarning(msg.format(nodeid)))
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
====================================================================== slowest 5 durations ======================================================================
0.07s call tests/integration_tests/test_vectorstores.py::test_chroma
0.03s call tests/integration_tests/test_vectorstores.py::test_chroma_with_persistence
0.01s call tests/integration_tests/test_vectorstores.py::test_chroma_update_document
0.01s call tests/integration_tests/test_vectorstores.py::test_reset_collection
0.01s call tests/integration_tests/test_vectorstores.py::test_chroma_search_filter_with_scores
==================================================================== short test summary info ====================================================================
FAILED tests/integration_tests/test_vectorstores.py::test_chroma_update_document - ValueError: The truth value of an array with more than one element is ambiguous. Use a.any() or a.all()
====================================================== 1 failed, 24 passed, 4 skipped, 1 warning in 0.78s =======================================================I'm willing to call |
13 tasks
|
Result of 10 packages marked as broken and skipped:
8 packages built:
|
|
Looks like you are good to merge. When you mark it ready to merge, I'll give the LGTM. |
|
Result of 4 packages marked as broken and skipped:
14 packages built:
|
natsukium
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Diff: chroma-core/chroma@refs/tags/0.5.7...0.5.11
Changelog: https://github.com/chroma-core/chroma/releases/tag/0.5.11
Description of changes
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.