Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kcl: 0.9.8 -> 0.10.0 #345613

Merged
merged 1 commit into from
Oct 10, 2024
Merged

kcl: 0.9.8 -> 0.10.0 #345613

merged 1 commit into from
Oct 10, 2024

Conversation

selfuryon
Copy link
Contributor

@selfuryon selfuryon commented Sep 30, 2024 •
edited
Loading

Description of changes

Update kcl, kclvm and kclvm-cli to the latest version (v0.10.0)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.
@Peefy

@momeemt
Copy link
Member

momeemt commented Oct 1, 2024

Result of nixpkgs-review pr 345613 run on aarch64-darwin 1

3 packages failed to build:
  • kcl
  • kclvm
  • kclvm_cli

@momeemt
Copy link
Member

momeemt commented Oct 1, 2024

I received the following error when I built this package.

exporting https://github.com/kcl-lang/rust-protoc-bin-vendored (rev 53c1f87ffc3027642ea6b822025b1dc699a3135b) into /nix/store/vsf9ga9iy9y50dwg9c4yycd7qylxkmjd-rust-protoc-bin-vendored-53c1f87
Initialized empty Git repository in /nix/store/vsf9ga9iy9y50dwg9c4yycd7qylxkmjd-rust-protoc-bin-vendored-53c1f87/.git/
fatal: unable to access 'https://github.com/kcl-lang/rust-protoc-bin-vendored/': OpenSSL/3.0.14: error:16000069:STORE routines::unregistered scheme
fatal: unable to access 'https://github.com/kcl-lang/rust-protoc-bin-vendored/': OpenSSL/3.0.14: error:16000069:STORE routines::unregistered scheme
fatal: unable to access 'https://github.com/kcl-lang/rust-protoc-bin-vendored/': OpenSSL/3.0.14: error:16000069:STORE routines::unregistered scheme
Unable to checkout 53c1f87ffc3027642ea6b822025b1dc699a3135b from https://github.com/kcl-lang/rust-protoc-bin-vendored.

@Peefy
Copy link
Contributor

Peefy commented Oct 1, 2024

LGTM.

@selfuryon
Copy link
Contributor Author

selfuryon commented Oct 1, 2024 •
edited
Loading

OpenSSL/3.0.14: error:16000069:STORE routines::unregistered scheme

@momeemt
Sorry, I haven't darwin to test, but your error looks like that and seems not related to kcl itself, more like to ca-bundle?

Edit2: I found almost the same error for macos nix here

@selfuryon
Copy link
Contributor Author

@momeemt Hey! Did you manage to run kcl on your macos?

@YvanDaSilva
Copy link
Contributor

YvanDaSilva commented Oct 2, 2024 •
edited
Loading

@selfuryon @Peefy @momeemt
I could build locally no issue on darwin. I will update the comment in a bit with the outputs.

aarch64-darwin

sysctl kern.version
kern.version: Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6030

./result/bin/kcl --version
kcl version v0.10.0

Just a file to test that binary does something kcl related

cat pkgs/by-name/kc/hello.k
hello = "KCL 0.10.0"

./result/bin/kcl pkgs/by-name/kc/hello.k
hello: KCL 0.10.0

compilation

 git log
commit 7c0aa0521d0c350b3900eabbaf8a43cdd9ccf414 (HEAD, selfuryon/chore/kcl-update)
Author: Sergey Yakovlev <selfuryon@pm.me>
Date:   Tue Oct 1 02:37:16 2024 +0300

    kcl: 0.9.8 -> 0.10.0
...

export NIXPKGS=/Users/xxxxx/Projects/cloned/nixpkgs
nix-build $NIXPKGS -A kcl
...
unpacking source archive /nix/store/2wy1ph0zzsapxf3fsl5s6y3cwp2ci3n7-source
source root is source
Running phase: patchPhase
Running phase: updateAutotoolsGnuConfigScriptsPhase
Running phase: configurePhase
Running phase: buildPhase
Building subPackage ./cmd/kcl
Running phase: checkPhase
?       kcl-lang.io/cli/cmd/kcl [no test files]
Running phase: installPhase
Running phase: fixupPhase
checking for references to /private/tmp/nix-build-kcl-0.10.0.drv-0/ in /nix/store/5z0rvlx639in2asmzyxmv6xr59xd7yn2-kcl-0.10.0...
patching script interpreter paths in /nix/store/5z0rvlx639in2asmzyxmv6xr59xd7yn2-kcl-0.10.0
/nix/store/5z0rvlx639in2asmzyxmv6xr59xd7yn2-kcl-0.10.0

> eza -lha --no-user result/bin
Permissions Size Date Modified Name
.r-xr-xr-x   71M  1 Jan  1970  .kcl-wrapped
.r-xr-xr-x  1.4k  1 Jan  1970  kcl

@selfuryon selfuryon requested a review from NickCao October 4, 2024 09:10
@selfuryon selfuryon self-assigned this Oct 4, 2024
@selfuryon
Copy link
Contributor Author

@selfuryon @Peefy @momeemt I could build locally no issue on darwin. I will update the comment in a bit with the outputs.

aarch64-darwin

sysctl kern.version
kern.version: Darwin Kernel Version 23.6.0: Mon Jul 29 21:14:30 PDT 2024; root:xnu-10063.141.2~1/RELEASE_ARM64_T6030

./result/bin/kcl --version
kcl version v0.10.0

Just a file to test that binary does something kcl related

cat pkgs/by-name/kc/hello.k
hello = "KCL 0.10.0"

./result/bin/kcl pkgs/by-name/kc/hello.k
hello: KCL 0.10.0

compilation

 git log
commit 7c0aa0521d0c350b3900eabbaf8a43cdd9ccf414 (HEAD, selfuryon/chore/kcl-update)
Author: Sergey Yakovlev <selfuryon@pm.me>
Date:   Tue Oct 1 02:37:16 2024 +0300

    kcl: 0.9.8 -> 0.10.0
...

export NIXPKGS=/Users/xxxxx/Projects/cloned/nixpkgs
nix-build $NIXPKGS -A kcl
...
unpacking source archive /nix/store/2wy1ph0zzsapxf3fsl5s6y3cwp2ci3n7-source
source root is source
Running phase: patchPhase
Running phase: updateAutotoolsGnuConfigScriptsPhase
Running phase: configurePhase
Running phase: buildPhase
Building subPackage ./cmd/kcl
Running phase: checkPhase
?       kcl-lang.io/cli/cmd/kcl [no test files]
Running phase: installPhase
Running phase: fixupPhase
checking for references to /private/tmp/nix-build-kcl-0.10.0.drv-0/ in /nix/store/5z0rvlx639in2asmzyxmv6xr59xd7yn2-kcl-0.10.0...
patching script interpreter paths in /nix/store/5z0rvlx639in2asmzyxmv6xr59xd7yn2-kcl-0.10.0
/nix/store/5z0rvlx639in2asmzyxmv6xr59xd7yn2-kcl-0.10.0

> eza -lha --no-user result/bin
Permissions Size Date Modified Name
.r-xr-xr-x   71M  1 Jan  1970  .kcl-wrapped
.r-xr-xr-x  1.4k  1 Jan  1970  kcl

Thanks!

@momeemt
Copy link
Member

momeemt commented Oct 8, 2024

Result of nixpkgs-review pr 345613 run on aarch64-darwin 1

3 packages built:
  • kcl
  • kclvm
  • kclvm_cli

momeemt
momeemt approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@momeemt momeemt left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@selfuryon I am really sorry for the very late reply, I missed the mentions. I reinstalled Nix and set up the certificates and it builds fine in my local environment, Thank you for your contribution!

@selfuryon
Copy link
Contributor Author

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

@selfuryon merge not permitted (#305350):
pr author is not in restricted authors list, in the list are: r-ryantm

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/2028

@katexochen katexochen merged commit b0323d9 into NixOS:master Oct 10, 2024
33 checks passed
@selfuryon selfuryon deleted the chore/kcl-update branch October 10, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@momeemt momeemt momeemt approved these changes

@NickCao NickCao Awaiting requested review from NickCao

Assignees

@selfuryon selfuryon

Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer 12.approvals: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@selfuryon @momeemt @Peefy @YvanDaSilva @nixos-discourse @katexochen