Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

waveterm: init at 0.8.7 #345714

Merged
merged 2 commits into from
Oct 2, 2024
Merged

waveterm: init at 0.8.7 #345714

merged 2 commits into from
Oct 2, 2024

Conversation

aucub
Copy link
Contributor

@aucub aucub commented Oct 1, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd try to get the darwin builds and aarch64 builds as well. Examples in #330918

@JohnRTitor
Copy link
Contributor

Thanks, aarch64/arm64 could be added as well?

@aucub
Copy link
Contributor Author

aucub commented Oct 1, 2024

Thanks, aarch64/arm64 could be added as well?

I will try to add linux-aarch64, but I am unable to test it on the device.

@JohnRTitor
Copy link
Contributor

Sure, it's just getting the binary tarball, should just work as long as it builds I believe, I can try to run it with binfmt emulation.

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good except for the few nits above. I'll try a build once those are fixed.

For darwin CC @DontEatOreo for checking if it builds but I am afraid to use the package on Darwin we might need to do #330918 (comment)

Note: as of now all CI passes (darwin and linux)

@JohnRTitor
Copy link
Contributor

Result of nixpkgs-review pr 345714 run on x86_64-linux 1

1 package built:
  • waveterm

@JohnRTitor
Copy link
Contributor

JohnRTitor commented Oct 2, 2024

Result of nixpkgs-review pr 345714 run on aarch64-linux 1

EDIT: builds on aarch64-linux without an issue

Copy link
Contributor

@JohnRTitor JohnRTitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this done, I assume darwin too is fine since the CI is green.

@JohnRTitor JohnRTitor merged commit 3b266ab into NixOS:master Oct 2, 2024
27 checks passed
@aucub aucub deleted the waveterm branch October 2, 2024 11:48
@DontEatOreo
Copy link
Member

Sorry for the late reply, but I have same question as I did in #330918 (comment)

@JohnRTitor
Copy link
Contributor

Indeed we should, but I did not want to block this PR.

@DontEatOreo Another thing, if 7zz corrupts the macos package, can we just use hdiutil, Official one is closed source, but there is a third party package that implements some functionality (attach and detach is all we need)
https://github.com/go-darwin/hdiutil . It is pretty old, could you investigate if this still works?

@DontEatOreo
Copy link
Member

I will take a look. I think maybe a hacky alternative could be to just have a Bash or Python script run xattr -d com.apple.quarantine on it, which would remove the warning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: waveterm
4 participants