-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
waveterm: init at 0.8.7 #345714
waveterm: init at 0.8.7 #345714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd try to get the darwin builds and aarch64 builds as well. Examples in #330918
1c54342
to
24cb70c
Compare
Thanks, |
I will try to add linux-aarch64, but I am unable to test it on the device. |
Sure, it's just getting the binary tarball, should just work as long as it builds I believe, I can try to run it with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good except for the few nits above. I'll try a build once those are fixed.
For darwin CC @DontEatOreo for checking if it builds but I am afraid to use the package on Darwin we might need to do #330918 (comment)
Note: as of now all CI passes (darwin and linux)
Result of 1 package built:
|
Result of EDIT: builds on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this done, I assume darwin too is fine since the CI is green.
Sorry for the late reply, but I have same question as I did in #330918 (comment) |
Indeed we should, but I did not want to block this PR. @DontEatOreo Another thing, if 7zz corrupts the macos package, can we just use hdiutil, Official one is closed source, but there is a third party package that implements some functionality ( |
I will take a look. I think maybe a hacky alternative could be to just have a Bash or Python script run |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.