-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rio: Restrict test execution inside nixosTests for Linux devices #345722
Conversation
This affects practically every package with a linked nixos test, can we find a solution for them all? E.g. make nixos tests work on darwin, nothing stop us from running qemu there. |
This would be for sure the best solution, however I don't have access for the Darwin. So, I believe that someone using this operating system will need to work on that. Meanwhile, I think that this should not forbid the value of this pull request, as this solves a real problem and other derivations do the same already. |
Could you open a tracking issue (if there isn't one already) and link to it in a comment. So we can just grep and replace all the occurrences of this hack when the underlying issue is fixed. |
The PR that introduced this problem: #303597 |
@NickCao Honestly, I don't have too much detail about the Darwin issue, so it would be better if someone with more involvement in Darwin can report that. I'm totally fine to update the code and the commit log to mention this issue so it can be searched in the future. Don't get me wrong, I'm fine in reporting issues, just I don't have the details to be able to do a proper issue with helpful information. @mattpolzin Could you help on that? |
Also cc @wegank |
Sure, I can write up a ticket. I actually didn't realize this was related to only recently starting to run the nixos tests on darwin at all; thanks for the link Nick. [EDIT] as indicated in the GitHub feed for this PR as well, the ticket I opened can be found here: #345825 |
Restrict test execution inside nixosTests for Linux devices as ofborg 'passthru.tests' nixosTests are failing on Darwin architectures. Ref: NixOS#345825 Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
@mattpolzin I have applied the changes to this pull request. Could you review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. We may as well let the aarch64-darwin test play out (though clearly things are being skipped as desired for the already-finished x86_64-darwin passthru tests) before merging.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.