-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plex-desktop: remove version number from name #345754
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detroyejr
force-pushed
the
plex-desktop-name
branch
from
October 1, 2024 19:23
8bb0ff7
to
32ecc5b
Compare
detroyejr
force-pushed
the
plex-desktop-name
branch
from
October 1, 2024 20:03
32ecc5b
to
45fe7e3
Compare
SuperSandro2000
requested changes
Oct 1, 2024
detroyejr
force-pushed
the
plex-desktop-name
branch
2 times, most recently
from
October 1, 2024 20:33
63a53dd
to
1d3d217
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otherwise LGTM
detroyejr
force-pushed
the
plex-desktop-name
branch
from
October 2, 2024 15:14
1d3d217
to
3a6a8c3
Compare
SuperSandro2000
approved these changes
Oct 2, 2024
Frontear
reviewed
Oct 2, 2024
Replaces NixOS#328708 and closes NixOS#345618
detroyejr
force-pushed
the
plex-desktop-name
branch
from
October 2, 2024 16:57
3a6a8c3
to
4e3b69e
Compare
Frontear
reviewed
Oct 2, 2024
SuperSandro2000
approved these changes
Oct 6, 2024
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plex-desktop: remove version number from name.
The command
plex-desktop-1.96.0
becomesplex-desktop
and won't change when the package is updated.Closes #345618.
Replaces: #328708 - Also included 2 small changes from a previous unmerged PR.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.