Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

klog-rs: init at 0.0.3 #345863

Merged
merged 2 commits into from
Oct 29, 2024
Merged

klog-rs: init at 0.0.3 #345863

merged 2 commits into from
Oct 29, 2024

Conversation

tobifroe
Copy link
Member

@tobifroe tobifroe commented Oct 2, 2024

This adds klog-rs, a small utility simplifying the process of working with Kubernetes logs.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor

@SigmaSquadron SigmaSquadron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to Nixpkgs! I'm sorry this went unreviewed; the diff looks very high-quality.

pkgs/by-name/kl/klog-rs/package.nix Outdated Show resolved Hide resolved
Copy link
Member

@h7x4 h7x4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to nixpkgs 🎉

I havent' tested the kubernetes part, but everything compiles correctly. The diff looks good.

Could you fix up your commits? Optimally it should be two commits like this. Make sure to order the maintainer list change before the package commit.

maintainers: add tobifroe
klog-rs: init at 0.0.3

pkgs/by-name/kl/klog-rs/package.nix Show resolved Hide resolved
@tobifroe
Copy link
Member Author

Thank you for reviewing my PR, I just reordered and squashed my commits. Is there anything else for me to do?

@h7x4
Copy link
Member

h7x4 commented Oct 27, 2024

Everything looks good. Verified the github id and the license upstream.

Could you rebase your commits on main? ofborg is throwing a fit, but I don't think it's a problem with your code

@tobifroe
Copy link
Member Author

Thank you @h7x4, just rebased on main

@h7x4
Copy link
Member

h7x4 commented Oct 28, 2024

It looks like darwin needs some extra libraries for the program to compile. You could either mark it as broken on darwin, or try to fix it up. I'm not too familiar with it, but there should be plenty of people to ping if you need any help :)

@tobifroe
Copy link
Member Author

I just marked it as broken for now, I'll look into this in the future though. :)

@h7x4
Copy link
Member

h7x4 commented Oct 28, 2024

I think you might've forgotten to stage the changes or something. The last forcepush didn't seem to have changed anything.

@Aleksanaa
Copy link
Member

Just wait for this staging-next till tomorrow. Completing darwin.apple_sdk.frameworks.xxx won't be necessary after that

@Aleksanaa Aleksanaa merged commit 789c940 into NixOS:master Oct 29, 2024
28 of 29 checks passed
@tobifroe tobifroe deleted the init-klog-rs branch October 29, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants