-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
klog-rs: init at 0.0.3 #345863
klog-rs: init at 0.0.3 #345863
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to Nixpkgs! I'm sorry this went unreviewed; the diff looks very high-quality.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to nixpkgs 🎉
I havent' tested the kubernetes part, but everything compiles correctly. The diff looks good.
Could you fix up your commits? Optimally it should be two commits like this. Make sure to order the maintainer list change before the package commit.
maintainers: add tobifroe
klog-rs: init at 0.0.3
a36d527
to
3041b2f
Compare
Thank you for reviewing my PR, I just reordered and squashed my commits. Is there anything else for me to do? |
Everything looks good. Verified the github id and the license upstream. Could you rebase your commits on main? ofborg is throwing a fit, but I don't think it's a problem with your code |
3041b2f
to
32fa50f
Compare
Thank you @h7x4, just rebased on main |
It looks like darwin needs some extra libraries for the program to compile. You could either mark it as broken on darwin, or try to fix it up. I'm not too familiar with it, but there should be plenty of people to ping if you need any help :) |
32fa50f
to
7933d51
Compare
I just marked it as broken for now, I'll look into this in the future though. :) |
I think you might've forgotten to stage the changes or something. The last forcepush didn't seem to have changed anything. |
Just wait for this staging-next till tomorrow. Completing |
7933d51
to
eb2c719
Compare
eb2c719
to
da26ed2
Compare
This adds klog-rs, a small utility simplifying the process of working with Kubernetes logs.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.