[Backport release-24.05] percona: update packages, init 8.4 #346437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osnyx
force-pushed
the
PL-132970-percona-84-backport
branch
from
00890ad
to
6ed6297
Compare
|
Updated the backport according to the changes in #346027. |
Ma27
reviewed
Oct 14, 2024
I encountered errors when attempting to run Vitess which calls out to mysqld_safe[1]. Several utilities are needed in order for it to run e.g. grep, sed, env, ps, date, hostname, etc. Additionally, if ps, kill, and grep aren't available to scripts/CMakeLists.txt, mysqld_start can end up getting generated with syntax errors as FIND_PROC will be substituted into the script template as an empty string[2][3]. The presence of systemd in percona-server_innovation seems to prevent mysqld_multi from being built on Linux so it gets patched conditionally. This same patch could be applied to MySQL if desired. [1]: https://github.com/vitessio/vitess/blob/v20.0.1/go/vt/mysqlctl/mysqld.go#L363-L369 [2]: https://github.com/percona/percona-server/blob/79c1086e8272ea96f162b25121b58e1b01ff853b/scripts/CMakeLists.txt#L255 [3]: https://github.com/percona/percona-server/blob/79c1086e8272ea96f162b25121b58e1b01ff853b/scripts/mysqld_safe.sh#L869 (cherry picked from commit a5dcd41)
When reworking the percona package naming towards the two release streams "innovation" and "lts", I did not anticipate the case that two releases are long-term supported in parallel, and that the latest Innovation release is end-of-life and replaced by a more recent lts. Hence, the first-level attribute names now reflect the package major-minor versions again, augmented by attribute names pointing to respective lts and innovation releases. (cherry picked from commit 188b5df)
This is a new LTS release as well. (cherry picked from commit 712028e)
This is a new LTS release as well. (cherry picked from commit b04c93f)
(cherry picked from commit a309521)
(cherry picked from commit 1e514dc)
(cherry picked from commit 8d14fa2)
(cherry picked from commit db92bb5)
In the stable branch, the `_lts` package names for percona-server and percona-xtrabackup remain at the still suported 8_0 packages to avoid major version bumps during a release cycle.
osnyx
force-pushed
the
PL-132970-percona-84-backport
branch
from
ae040bb
to
faa0c49
Compare
Ma27
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #346027.
Main difference is that the
_ltspackage names continue to point at the 8_0 release stream, to avoid a major release change within the 24.05 release cycle.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.