zen-browser: init at 1.0.1-a.16 #347222
zen-browser: init at 1.0.1-a.16 #347222
Conversation
matthewpi
force-pushed
the
zen-browser
branch
4 times, most recently
from
4484966
to
ddda268
Compare
Could you please add me as a maintainer? I'm really happy I could be a maintainer in Nixpkgs :D |
|
I too would like to be added as a maintainer for this package if possible :) |
In order to be added as a maintainer you need to have an entry in I'm not sure if I'm supposed to add you as nixpkgs would likely prefer users add themselves rather than getting someone else to do it for them. |
|
After ~2 hours on my laptop, it built. Typing from the browser right now! Seems functionally it works fine :) |
|
Hey ! Could I be added as a maintainer too ? |
Is it allowed to add others to maintainers list in a pull request? Or may I add my self at next update? 🤔 |
It is preferable for users to add themselves. At least, the commit must be authored and signed by the added user. If @matthewpi gives you a write access to its fork's branch, you would be able to add yourself and the change will be in this MR. |
|
Hey ➜ nix run nixpkgs#nixpkgs-review -- pr --print-result 347222 --no-shell
[...]
[1/0/2 built] building zen-browser-unwrapped-1.0.1-a.7 (buildPhase): 00:22:21 Javascript error: chome://browser/content/parent/ext-browser.js, line: TypeError: currentTab.linkedBrowser is null Does someone got the same ? The thing is the build seems to be stuck forever in this state |
How powerful is the system you are building this on? It's not uncommon for the output to become "stuck" and not print anything for awhile, especially on lower-end systems. |
Well, I am not really on lower-end gear (Ryzen 9 5900X, 32 Go of RAM) but good news, the build is continuing. 1 package built: Result of 1 package built:
|
That is not a build failure. The build continues and succeeds. I saw the same log message, but it had no effect on the success of the build. |
|
New release pushed with critical security fixes (from upstream firefox): https://github.com/zen-browser/desktop/releases/tag/1.0.1-a.8 |
|
So, did a complete zen-browser build as of their docs describe here: https://docs.zen-browser.app/building without issue. |
Okay it doesn't answer this |
|
@Eveeifyeve : It was in response to my previous post:
Running |
Not if you clone this pr locally. |
matthewpi
force-pushed
the
zen-browser
branch
from
d607bf5
to
f7aceec
Compare
matthewpi
changed the title
I ran the command in the repo I failed to build zen-browser in, running |
Flake or no flake system config? |
no flake |
Do you have a channel set? |
I don't think it is a system problem I have. I build zen-browser using their recommended method and it worked fine. It used surfer as a buildtool, just the outcome was a non-branded zen-browser version. It too used all cores to build but did not end up using too much ram. So there seems to be a difference in the build settings. On another topic: why not repackage the binary provided by the github-project of zen browser instead of building the whole thing from scratch? |
|
It took me around 50 minutes using a server with 2x14 cores (56 threads). I didn't get any obvious errors during building, but I am not unable to try it out (maybe tomorrow). EDIT While running
|
I just put some MWE together and it seems to be running, but I haven't tested it much. It is available on my flake repo. |
Because binaries are not as auditable, and now you're trusting those builds. Plus you can do more with a package that actually compiles it :p |
i wish i could, but i can't get it to work lol. and my 'budget' for packages that take forever to build is tight. (though even once this is binary cached, no guarantees some other part of my system is going to impact my ability to use it)
i tried this |
You can just run |
thank you for reply, i just wanted it running on my local system for use more than testing. :-) i did try building it just now and i get a similar error i get same error using the |
Building from source aligns with Nix's reproducibility idea: if it can be built in some environment, then it should work fine in that environment. For Zen, finding an efficient way to build it might take a while. In the meantime, you can use a flatpack version I tried and it's working fine (the generic version is expected to be slower than building it from the source) just need to enable flatpak on NixOS |
flatpak does work but presents a few other flatpak-related issues that running natively doesn't present. |
matthewpi
force-pushed
the
zen-browser
branch
from
f7aceec
to
e5ba835
Compare
matthewpi
changed the title
I use SSH keys to sign all my commits, but there is no section or property for listing those for maintainers. To avoid confusion I'm removing my unused GPG keys. Signed-off-by: Matthew Penner <me@matthewp.io>
Signed-off-by: Matthew Penner <me@matthewp.io>
matthewpi
force-pushed
the
zen-browser
branch
from
e5ba835
to
7f331be
Compare
https://zen-browser.app/
Closes #327982
Needs testing on darwin and aarch64-linux systems.
NOTE: This package takes quite a lot of resources to build. On my desktop (7900X) and on my build server (5950X) the build takes upwards of about 30-35 minutes. This is not a package you want to compile yourself if you can avoid it.
If anyone wants to be added as a maintainer to this package, please leave a comment and I will add you.
@Zh40Le1ZOOB thanks for doing the legwork to get this packaged. I based this package on the one you linked in the associated package request, but merged in a bunch of the options from the
firefoxpackage already in nixpkgs.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.