Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vscodium: 1.88.1 -> 1.94.1 #347691

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Conversation

drupol
Copy link
Contributor

@drupol drupol commented Oct 10, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@drupol drupol mentioned this pull request Oct 10, 2024
13 tasks
@drupol drupol changed the title vscodium: 1.94.0 -> 1.94.1 vscodium: 1.88.1 -> 1.94.1 Oct 10, 2024
@drupol drupol merged commit 6c8a54f into NixOS:release-24.05 Oct 10, 2024
24 of 27 checks passed
@drupol drupol deleted the push-zzouqzqqykzl branch October 10, 2024 11:31
@bobby285271
Copy link
Member

Did you test darwin?

@drupol
Copy link
Contributor Author

drupol commented Oct 10, 2024

Nope, I can't test it, I'm not using it. I usually skip the Darwin tests for 2 reasons:

  1. I don't own a Darwin machine where I could test
  2. It often takes too much time, even on the CI

@bobby285271
Copy link
Member

bobby285271 commented Oct 10, 2024

Whatever the reason is, can you please backport d221491 ? (I am typing this on a phone and won't be next to a laptop in hours)

(it will be nice if you can wait reasonably longer before merge in this case I guess, for me sometimes I use custom github actions for trivial darwin build testing)

@drupol
Copy link
Contributor Author

drupol commented Oct 10, 2024

OK will do the rest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants