[Backport release-24.05] legcord: init at 1.0.1, armcord: remove, add throw with migration details

[wrmilling]

Things done

ArmCord was renamed to Legcord and re-versioned to 1.0.0 upstream, see the release notes for details on this change. Updated to 1.0.1 while waiting on change reviews for this PR.

Context and discussion can be found on the PR to unstable: #347971

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[emilazy]

       … while evaluating attribute 'buildPhase' of derivation 'legcord-1.0.0'

         at /home/emily/.cache/nixpkgs-review/pr-347988/nixpkgs/pkgs/by-name/le/legcord/package.nix:31:3:

           30|
           31|   buildPhase = ''
             |   ^
           32|     runHook preBuild

       error: attribute 'dist' missing

       at /home/emily/.cache/nixpkgs-review/pr-347988/nixpkgs/pkgs/by-name/le/legcord/package.nix:38:26:

           37|       --dir \
           38|       -c.electronDist="${electron_32.dist}" \
             |                          ^
           39|       -c.electronVersion="${electron_32.version}"

Not quite sure what’s going on there (source vs. binary package difference?).

[wrmilling]

Not quite sure what’s going on there (source vs. binary package difference?).

I must have had something cached locally when I tested, thanks for the catch on this. Not knowing what else we will encounter between a source build on 24.05 vs on master, I am going to just revert to the deb-based packaging that we were doing with armcord/legcord already on 24.05 and let it be retired when 24.05 goes out of support.

[wrmilling]

@emilazy Apologies for the direct ping, could you take a second look and let me know if we need any more changes? Just want to close the loop on the armcord/legcord thing.

[emilazy]

No worries about the ping, I think I was waiting for ofborg and then forgot about it ^^;

LGTM, thank you for dealing with this.