Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uefi-firmware-parser: init at 1.12 #349032

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

KSJ2000
Copy link
Contributor

@KSJ2000 KSJ2000 commented Oct 16, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@KSJ2000
Copy link
Contributor Author

KSJ2000 commented Oct 16, 2024

I don't understand.
This package is in 24.05 from #62100, but then it was removed from unstable with the following message in pkgs/top-level/aliases.nix:

uefi-firmware-parser = throw "The uefi-firmware-parser package was dropped since it was unmaintained."; # Added 2024-06-21

which makes it to fail the nixpkgs-vet, for the unmaintained reason which is not correct:
https://github.com/theopolis/uefi-firmware-parser/commits/master/

@markuskowa
Copy link
Member

This was dropped here #321436, when samueldr left nixpkgs.
You have to remove the respective entry from pkgs/top-level/aliases.nix.

@KSJ2000 KSJ2000 marked this pull request as ready for review November 1, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants