stellarium: make qtwebengine an optional dependency #349497
Open
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aleksanaa
approved these changes
Oct 29, 2024
|
@Aleksanaa Did you mean to mark this pull request as a Draft, or was that accidental? |
|
@ofborg build stellarium |
|
It still doesn't build on darwin. Also please rebase to latest master before you test on your branch, because there's some significant change in darwin toolchain. |
This commit makes `qtwebengine` an optional dependency for stellarium. Since `qtwebengine` currently fails to build on Darwin, it is now disabled by default for that platform.
kilianar
force-pushed
the
stellarium-qtwebengine
branch
from
b680c0f
to
9d4379b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request makes
qtwebenginean optional dependency for stellarium. Sinceqtwebenginecurrently fails to build on Darwin, it is now disabled by default for that platform.Since I do not have access to a Darwin machine, it would be helpful if someone could verify that stellarium now builds and runs on Darwin before this PR is merged.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.