-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cargo-tauri.hook: use finalPackage as cargo-tauri #350002
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I hadn't thought of something like this before
The related question that still remains is how to package cargo_tauri_2 and how a cargo-tauri_2 vs cargo-tauri_1 split will work inside pkgs/by-name
That's being done in #346277, which this will be a major help in (and should now be merged after this)
Okay, I just put |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the wait. Moving meta and passthru to the overrideAttrs arguments is fine with me. Thanks!
This PR simplifies usage of cargo-tauri.hook when cargo-tauri is overridden
This PR should not cause any rebuilds.
The related question that still remains is how to package
cargo_tauri_2
and how acargo-tauri_2
vscargo-tauri_1
split will work insidepkgs/by-name
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.