-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jellyseerr: 1.9.2 -> 2.0.1 #350376
Closed
Closed
jellyseerr: 1.9.2 -> 2.0.1 #350376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmir1
approved these changes
Oct 29, 2024
camillemndn
approved these changes
Oct 29, 2024
FliegendeWurst
suggested changes
Oct 30, 2024
}; | ||
|
||
packageJSON = ./package.json; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also delete package.json
.
pkgs/servers/jellyseerr/default.nix
Outdated
Comment on lines
84
to
86
license = licenses.mit; | ||
maintainers = with maintainers; [ camillemndn ]; | ||
platforms = platforms.linux; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
license = licenses.mit; | |
maintainers = with maintainers; [ camillemndn ]; | |
platforms = platforms.linux; | |
license = lib.licenses.mit; | |
maintainers = with lib.maintainers; [ camillemndn ]; | |
platforms = lib.platforms.linux; |
(removing with lib;
)
This is better handled in the cc-wrapper, and makes it possible to avoid rebuilding clang in some scenarios. It also appears to be unnecessary since the cc-wrapper already passes -stdlib=libc++ where needed. See: https://github.com/NixOS/nixpkgs/blob/8885a1e21ad43f8031c738a08029cd1d4dcbc2f7/pkgs/build-support/cc-wrapper/default.nix#L603 Signed-off-by: Peter Waller <p@pwaller.net>
While gleam can be run entirely off JS backend, a lot of its intended uses are in the backend where its target is BEAM VM of Erlang. Current Gleam version requires Erlang/OTP 26 (erlang_26), while nixpkgs still defaults to Erlang/OTP 25 (erlang). This change fixes that.
Diff: geopython/OWSLib@refs/tags/0.31.0...0.32.0 Changelog: https://github.com/geopython/OWSLib/releases/tag/0.32.0
Tool to extract subdomains from SSL certificates in HTTPS sites https://github.com/franccesco/getaltname
github-actions
bot
added
6.topic: TeX
Issues regarding texlive and TeX in general
6.topic: lua
6.topic: testing
Tooling for automated testing of packages and modules
6.topic: nim
Nim programing language
6.topic: vscode
6.topic: lib
The Nixpkgs function library
6.topic: php
8.has: maintainer-list (update)
6.topic: llvm/clang
Issues related to llvmPackages, clangStdenv and related
6.topic: flutter
6.topic: tcl
labels
Oct 30, 2024
nix-owners
bot
requested review from
aanderse,
adamcstephens,
adisbladis,
ajs124,
alyssais,
AndersonTorres,
arianvp,
bendlas,
drupol,
dtzWill,
edwtjo,
ehmry,
ElvishJerricco,
emilylange and
Ericson2314
October 30, 2024 18:52
Please recreate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
6.topic: emacs
6.topic: fetch
6.topic: flutter
6.topic: kernel
6.topic: lib
The Nixpkgs function library
6.topic: llvm/clang
Issues related to llvmPackages, clangStdenv and related
6.topic: lua
6.topic: nim
Nim programing language
6.topic: nixos
6.topic: nodejs
6.topic: ocaml
6.topic: pantheon
The Pantheon desktop environment
6.topic: php
6.topic: policy discussion
6.topic: printing
6.topic: python
6.topic: tcl
6.topic: testing
Tooling for automated testing of packages and modules
6.topic: TeX
Issues regarding texlive and TeX in general
6.topic: vim
6.topic: vscode
8.has: changelog
8.has: documentation
8.has: maintainer-list (update)
8.has: module (update)
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
12.approvals: 1
12.approvals: 2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/Fallenbagel/jellyseerr/releases/tag/v2.0.1
Fallenbagel/jellyseerr@v1.9.2...v2.0.1
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.