-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
junest: include VERSION file in the package so --version works properly #350561
base: master
Are you sure you want to change the base?
Conversation
Would be better to substitute https://github.com/fsquillace/junest/blob/0037f96e159a143e37db978e537e3fb362ba3a5b/bin/junest#L81 instead, since it's not a really good practice to add more nonstandard locations. Also |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
dc8f1e8
to
beef8d4
Compare
I opted to replace the cat command entirely with the package version. I added both the preInstall and postInstall hooks (I'm assuming that's what you meant). |
74ab68e
to
5db2933
Compare
Signed-off-by: jdev082 <jdev082@jdev.eu.org>
85e5b14
to
0f4ede2
Compare
substituteInPlace $out/lib/core/common.sh --replace-fail "wget" ${lib.getExe wget} | ||
|
||
runHook postInstall | ||
''; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bonus: to test --version
works correctly, add a https://nixos.org/manual/nixpkgs/unstable/#versioncheckhook
This pull request adds the file
VERSION
from the source code to the package so that the$ junest --version
works properly.Before this fix:
After this fix
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.