-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rPackages.ChemmineOB: fix compile error #351013
Conversation
@ofborg build rPackages.ChemmineOB |
Working on Linux, but failing on Darwin
|
They all seem to be warnings, can you search the log for the error? |
Click to expand
seems to be this:
Googling for the error message shows that other software have the same issue when being compiled with clang: https://bugs.gentoo.org/869170 here's a comment that could help:
|
Ah, forgot one more level of "or empty thing". |
- Don't override openbabel - fix pointer name in ChemmineOB src instead
Looks like CXXFLAGS weren't passed to the compiler. I try with NIX_CFLAGS_COMPILE. But if you know how to pass this to clang, don't hold back pls. For now, I put this PR in draft. |
@ofborg build rPackages.ChemmineOB |
your latest attempt works on aarch64-darwin 👍 |
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.