Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smlnj: add skyesoss as maintainer #351750

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Conversation

Skyb0rg007
Copy link
Contributor

This pull request adds skyesoss (myself) as a maintainer, and additionally adds myself as a maintainer for smlnj.

Pull request #329975 has not been responded to by the current maintainer for more than 90 days, and as a contributor to SML/NJ and Nix user I believe that I can maintain the nixpkgs version of the package.

Things done

There are two commits: one that adds myself as maintainer, and a second that adds myself as a maintainer of smlnj.
The current maintainer @thoughtpolice has not been active in package discussions, and I can add another commit removing them as a maintainer if this is desired.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I generally have a million things going on these days and GitHub's notification system is god-awful; there are many things I just don't have the bandwidth to reply to for various reasons ranging from "I missed it" to "I don't have time for substantial review" (and I occasionally have to declare "notification bankruptcy" as a result.) Nobody ever really wanted to take over smlnj so it's languished a little for years. However, I'm happy to see someone active in the SML world take it over. Approved.

@Aleksanaa Aleksanaa changed the title Add maintainer skyesoss to smlnj smlnj: add skyesoss as maintainer Oct 28, 2024
@Aleksanaa Aleksanaa merged commit d2382fe into NixOS:master Oct 28, 2024
35 of 36 checks passed
@Skyb0rg007 Skyb0rg007 deleted the add-maintainer branch October 28, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants