Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steampipePackages.steampipe-plugin-azure: init at 1.0.0 #351808

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

PeteE
Copy link
Contributor

@PeteE PeteE commented Oct 28, 2024

Description

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@anthonyroussel
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 351808


x86_64-linux

✅ 1 package built:
  • steampipePackages.steampipe-plugin-azure

aarch64-darwin

✅ 1 package built:
  • steampipePackages.steampipe-plugin-azure

@anthonyroussel
Copy link
Member

anthonyroussel commented Oct 28, 2024

Thank you, and welcome to the NixOS community!
Your PR looks good to me! 👍

However, there is just one error in the commit messages.
The PR should contain 2 separate commits for the package and the maintainer list addition:

  • maintainers: add petee
  • steampipePackages.steampipe-plugin-azure: init at 1.0.0

@PeteE PeteE force-pushed the steampipe-azure branch 3 times, most recently from dedaf56 to 1031b87 Compare October 29, 2024 04:38
@PeteE
Copy link
Contributor Author

PeteE commented Oct 29, 2024

Thank you, and welcome to the NixOS community! Your PR looks good to me! 👍

Thank you for the warm welcome! I'm excited to be here.

However, there is just one error in the commit messages. The PR should contain 2 separate commits for the package and the maintainer list addition:

* maintainers: add petee

I believe I've done this correctly (after many tries). I'm glad to learn some new git tricks today!

I will probably have a few more PRs coming for some of these steampipe plugins. :)

@anthonyroussel anthonyroussel changed the title steampipePackages.steampipe-plugins-azure: init at 1.0.0 steampipePackages.steampipe-plugin-azure: init at 1.0.0 Oct 29, 2024
@anthonyroussel anthonyroussel merged commit de2f9ce into NixOS:master Oct 29, 2024
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants