-
-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clash-rs: init at 0.7.0 #351974
clash-rs: init at 0.7.0 #351974
Conversation
Why are you targeting staging-next? (Instead of master) Is there something truly needed? |
There is no need, just wait for Rust 1.82 to reach the master branch. Maybe it should be set to draft now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
- builds as is
- builds with
versionCheckHook
additions - builds with extra features, see below
I noticed -F "shadowsocks, tuic, onion"
in the github ci workflow building the official binaries:
https://github.com/Watfaq/clash-rs/blob/98d183b04f96b8bcabe265af849713abeb5f40c3/.github/workflows/ci.yml#L48
Maybe add them to not differ from upstream?
buildFeatures = [ "shadowsocks" "tuic" "onion" ];
seems to work:
cargoBuildHook flags: -j 12 --target x86_64-unknown-linux-gnu --offline --profile release --features=shadowsocks,tuic,onion
ef61b97
to
7335f9c
Compare
ClashRS, A custom protocol, rule based network proxy software. https://github.com/Watfaq/clash-rs
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.