geis: fix build #352096
Merged
geis: fix build #352096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaneliman
reviewed
Oct 29, 2024
khaneliman
reviewed
Oct 29, 2024
zi3m5f
reviewed
Oct 29, 2024
ofborg
bot
added
10.rebuild-darwin: 0
10.rebuild-linux: 1-10
10.rebuild-linux: 1
labels
|
@zi3m5f Done. |
|
khaneliman
approved these changes
Oct 30, 2024
zi3m5f
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
LGTM 👍
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 352096
x86_64-linux
✅ 1 package built:
- geis
tests.pkg-config result:
✅ pkg-config module libgeis exists and has version 2.2.17
Aleksanaa
reviewed
Oct 31, 2024
| prePatch = '' | ||
| substituteInPlace python/geis/geis_v2.py --replace-fail \ | ||
| "ctypes.util.find_library(\"geis\")" "'$out/lib/libgeis.so'" | ||
| substituteInPlace config.aux/py-compile \ |
There was a problem hiding this comment.
This kind of systematic modification is best placed in a patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
geis: fix build
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.