Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.pygame-ce: 2.5.1 -> 2.5.2 #352150

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

pbsds
Copy link
Member

@pbsds pbsds commented Oct 29, 2024

Changelog: https://github.com/pygame-community/pygame-ce/releases/tag/2.5.2

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@natsukium
Copy link
Member

natsukium commented Oct 30, 2024

Result of nixpkgs-review pr 352150 at a944e83 run on aarch64-darwin 1

❌ 2 packages failed to build:
✅ 2 packages built:
  • python311Packages.pygame-ce
  • python312Packages.pygame-ce

Result of nixpkgs-review pr 352150 at a944e83 run on x86_64-linux 1

✅ 4 packages built:
  • python311Packages.pygame-ce
  • python311Packages.pygame-gui
  • python312Packages.pygame-ce
  • python312Packages.pygame-gui

@pbsds
Copy link
Member Author

pbsds commented Oct 30, 2024

Darwin sandbox strikes again! Reproduced the failure on master, hence this is not a regression. I'll disable the test for good measure anyway

@ofborg ofborg bot requested a review from emilytrau October 30, 2024 23:02
Copy link
Member

@natsukium natsukium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@natsukium natsukium merged commit fb6cb13 into NixOS:master Oct 31, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants