ycmd: correct gopls package and link path

[Melonai]

This fixes built-in Go completion support in vimPlugins.YouCompleteMe.

This essentially fixes two problems:

• ycmd previously used the package gotools to source it's gopls binary from, even though the binary has been removed from there in Update go tools/linters/language servers #85868 and moved to a separate package. Now we use the correct gopls package again.
• Upstream YCM has changed where the server binary is searched for by default. The defaults change is reflected in their install/build script (since Make sure gopls installed in bin folder ycm-core/ycmd#1427), as well as in the server implementation (since ycm-core/ycmd@f666d38). The link path has now been adjusted.

These two problems both contributed to gopls ending up a dangling symlink and breaking Go completion in YCM. After this it has been working correctly once again! :3

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Melonai]

Also, I did kinda notice that the YouCompleteMe plugin and its respective server generally haven't really been well maintained in quite a bit. From what it looks like, this issue in particular has been present for almost 4 years. ^^;
I can add myself as a maintainer and test and update the packages further, if there's interest. I haven't yet checked if the other built-in completion engines work yet, at least for now. ^_^ (Of course only with the other maintainers' approval, I don't want to step on anyone's toes haha)

[siriobalmelli]

I've since moved away from ycmd; in all fairness I'm no longer a maintainer here and would approve a commit removing me from the list if you deem it necessary.

[siriobalmelli]

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352222

---

aarch64-darwin

✅ 2 packages built:

• vimPlugins.YouCompleteMe
• ycmd

[Melonai]

I've since moved away from ycmd; in all fairness I'm no longer a maintainer here and would approve a commit removing me from the list if you deem it necessary.

@siriobalmelli If you'd like I can add a commit to this PR removing you from the maintainer role. That's up to you though!

Do you think it would be appropriate to add myself as package maintainer? I would like to see the plugin getting some love again! (With approval from the others, of course.)
Sorry, I'm all very new to this! :)

[siriobalmelli]

I'm in favor of removing myself as maintainer and adding you instead, thank you