Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-24.05] Firefox 132, Thunderbird 128.4.0 and more #352256

Merged
merged 12 commits into from
Oct 30, 2024
Merged

[release-24.05] Firefox 132, Thunderbird 128.4.0 and more #352256

merged 12 commits into from
Oct 30, 2024

Conversation

mweinelt
Copy link
Member

Backport #352161

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

mweinelt and others added 10 commits October 30, 2024 03:23
@mweinelt
nss_latest: 3.105 -> 3.106 (NixOS#350999)
b06ca0f 
(cherry picked from commit a8a2120)
@Scrumplex @mweinelt
buildMozillaMach: update system dir patch for Firefox 133+
866ebe4 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
(cherry picked from commit 2c6f04a)
@Scrumplex @mweinelt
firefox-unwrapped: 131.0.3 -> 132.0
e8bf56e 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
(cherry picked from commit a6b48a7)
@Scrumplex @mweinelt
firefox-esr-unwrapped: 128.3.1esr -> 128.4.0esr
dafea71 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
(cherry picked from commit 6c2d6f5)
@Scrumplex @mweinelt
firefox-beta-unwrapped: 132.0b9 -> 133.0b1
7127fc0 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
(cherry picked from commit 40a14b9)
@Scrumplex @mweinelt
firefox-devedition-unwrapped: 132.0b9 -> 133.0b1
013e947 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
(cherry picked from commit 2f28269)
@Scrumplex @mweinelt
firefox-bin-unwrapped: 131.0.3 -> 132.0
20b3400 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
(cherry picked from commit 9e89993)
@Scrumplex @mweinelt
firefox-beta-bin-unwrapped: 132.0b9 -> 133.0b1
4b057d8 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
(cherry picked from commit cb4dea9)
@Scrumplex @mweinelt
firefox-devedition-bin-unwrapped: 132.0b9 -> 133.0b1
0e80bdc 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
(cherry picked from commit 2c6fa9c)
@Scrumplex @mweinelt
thunderbirdPackages.thunderbird-128: 128.3.1esr -> 128.4.0esr
01d70c4 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
(cherry picked from commit 136e547)
@nix-owners nix-owners bot requested review from ajs124 and lukegb October 30, 2024 02:24
@Scrumplex
Copy link
Member

Betterbird (which was removed in #351205) uses Thunderbird 115. I guess we need to remove it or mark it as broken and remove references to thunderbird-115

@lukegb
Copy link
Contributor

lukegb commented Oct 30, 2024

On x86_64-linux:

firefox-115: errors (EOL), good
/nix/store/y1ckj126c6686ndn60w9grms8z2brkv9-firefox-132.0
/nix/store/ig6rmybqls73bxykvai1xb2nd4gd53xl-firefox-bin-132.0
/nix/store/383rsp8cyll8dds41nsmlr4bbf4ml7bl-firefox-133.0b1
/nix/store/2mr7b9sci9p61xsd0a2jbcgd3ci25p5b-firefox-beta-bin-133.0b1
/nix/store/7bkhnkqfc893g0da3569531qvphhq2h0-firefox-128.4.0esr
/nix/store/mc6r1lvnlhgqsxi3jz4qmzarn02y5c8k-thunderbird-128.4.0esr
/nix/store/iry64xhcrb7m94djy0l4qm9jsd7q8121-thunderbird-bin-128.4.0esr

@Scrumplex @mweinelt
thunderbird-bin-unwrapped: 128.4.0esr -> 128.4.0esr
08cecce 
Signed-off-by: Sefa Eyeoglu <contact@scrumplex.net>
(cherry picked from commit bfef141)
Scrumplex
Scrumplex requested changes Oct 30, 2024
View reviewed changes
Copy link
Member

@Scrumplex Scrumplex left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge blocker, as top level doesn't eval because of betterbird

@mweinelt
Copy link
Member Author

mweinelt commented Oct 30, 2024 •
edited
Loading

I dropped the Thunderbird 115 removal and marked it vulnerable instead.

Scrumplex
Scrumplex approved these changes Oct 30, 2024
View reviewed changes
Copy link
Member

@Scrumplex Scrumplex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM. betterbird and thunderbirdPackages.thunderbird-115 both refuse to evaluate because of knownVulnerabilities

@mweinelt mweinelt merged commit c4514c9 into NixOS:release-24.05 Oct 30, 2024
8 of 10 checks passed
@mweinelt mweinelt deleted the 24.05/firefox-132 branch October 30, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukegb lukegb lukegb approved these changes

@Scrumplex Scrumplex Scrumplex approved these changes

@ajs124 ajs124 Awaiting requested review from ajs124

Assignees
No one assigned
Labels
1.severity: security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mweinelt @Scrumplex @lukegb