Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird: bump 128 -> 132 #352493

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

booxter
Copy link
Contributor

@booxter booxter commented Oct 30, 2024

New thunderbird-latest and thunderbird-esr derivations are introduced. The default still follows esr.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@booxter
Copy link
Contributor Author

booxter commented Oct 30, 2024

I'm testing it on Darwin with #350384

@vcunat
Copy link
Member

vcunat commented Oct 31, 2024

#346493 (comment)

Upstream still doesn't inspire confidence in non-LTS releases, so at least I'd think we shouldn't make them the default?

@booxter
Copy link
Contributor Author

booxter commented Oct 31, 2024

I can flip the state so that ESR is the default, of course. We probably need a -esr alias as well as an alias for non-esr (not sure what the name for this derivation would be. thunderbird-latest?)

@vcunat I probably miss some context here. What are the issues with non-ESR releases in your mind?


UPD: I guess what is meant is this note from the release notes: "Thunderbird version 132.0 is available for testing purposes only." This is indeed different from how Firefox branches are positioned. I will update to keep ESR default.

The default `thunderbird` derivation will continue pointing to the
(latest) -esr release. The new `thunderbird-latest` derivation will
track non-esr releases (currently 132.0). The existing `thunderbird-128`
derivation is intact.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants