tclPackages.jimlib: init at 0.15.0 #352558
Conversation
maintainers/maintainer-list.nix
Outdated
There was a problem hiding this comment.
This should be a separate commit: maintainers: add neosloth
There was a problem hiding this comment.
Added as a separate commit
| cp $src/pkgIndex.tcl $out/lib/jimlib/pkgIndex.tcl | ||
| ''; | ||
|
|
||
| meta = with lib; { |
There was a problem hiding this comment.
We try to avoid with lib now. Use lib.platforms.all, lib.maintainers, and lib.licenses instead.
There was a problem hiding this comment.
Removed with lib
| meta = with lib; { | ||
| homepage = "https://wiki.tcl-lang.org/page/jimlib"; | ||
| description = "Jimlib is a personal standard library for Jim Tcl."; | ||
| license = licenses.mit; |
There was a problem hiding this comment.
From the readme:
MIT, Tcl, and BSD.
See the top of jimlib.tcl.
There was a problem hiding this comment.
Updated the license block. The line mentioning BSD ](https://gitlab.com/dbohdan/jimlib/-/blob/master/jimlib.tcl#L77 ) refers to code reused from tcllib, which is listed as Tcl licensed on nixpkgs.
Doesn't seem like there's a full license text included for BSD in either jimlib or upstream tcllib so I omitted it as I can't determine which version it was originally referring to
There was a problem hiding this comment.
According to dbohdan it's bsd3
20:48:31 <dbohdan[phone]> fgaz: You're welcome! I see one of the licenses listed for the package is
lib.licenses.bsd0. That's 0BSD, a rare public-domain-equivalent license. It is likely not what the developers oftry(dkf and aku) meant. While I am not sure what particular license they meant by "BSD licensed", I think the safe assumption islib.licenses.bsd3.
There was a problem hiding this comment.
Makes sense, thank you for checking. Updated
| ''; | ||
|
|
||
| meta = with lib; { | ||
| homepage = "https://wiki.tcl-lang.org/page/jimlib"; |
There was a problem hiding this comment.
I'm not sure the wiki page can be considered the official homepage. I'd use the gitlab page instead. Up to you.
There was a problem hiding this comment.
Gitlab makes sense to me, updated
|
|
||
| mkTclDerivation rec { | ||
| pname = "jimlib"; | ||
| version = "0.15.0-unstable-2024-10-31"; |
There was a problem hiding this comment.
Why do we need the unstable version?
There was a problem hiding this comment.
The git tag hasn't been updated in several years. This is the version in the source file, but there have been more commits since then that haven't bumped the version. Let me know if there's a more appropriate way to tag this
There was a problem hiding this comment.
The git tag hasn't been updated in several years
0.16.0 is now out. Ask and you shall receive :)
There was a problem hiding this comment.
Updated and set rev to use the new tag
Co-authored-by: Francesco Gazzetta <fgaz@fgaz.me>
https://gitlab.com/dbohdan/jimlib
Utility library for Jimtcl and Tcl.
Tested a few of the functions with Tcl 8.6, which is the current version for
mkTclDerivationThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.