Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant-lovelace-components.bubble-card: init at 2.2.4 #352588

Merged
merged 1 commit into from
Oct 31, 2024

Conversation

pta2002
Copy link
Contributor

@pta2002 pta2002 commented Oct 31, 2024

Packaged bubble-card, a custom home assistant lovelace component.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@mweinelt
Copy link
Member

Would be great if we could do the bundling ourselves, but the repo seems to lack a package.json and lock file for installing webpack. 😫

@pta2002
Copy link
Contributor Author

pta2002 commented Oct 31, 2024 via email

@pta2002 pta2002 changed the title home-assistant-lovelace-components.bubble-card: Add package home-assistant-lovelace-components.bubble-card: init at 2.2.4 Oct 31, 2024
@mweinelt mweinelt merged commit b0dce8f into NixOS:master Oct 31, 2024
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants