Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastfetch: switch to apple-sdk_15 #352623

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fastfetch: switch to apple-sdk_15 #352623

wants to merge 3 commits into from
+14 −33

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Oct 31, 2024 •
edited
Loading

Things done

Upstream uses @available and #ifdef checks for SDK features. Bumping to latest SDK and setting minimum
https://github.com/fastfetch-cli/fastfetch/blob/e0acce9646d7cd0b45506cf618d0401974b57875/src/detection/camera/camera_apple.m#L17-L25

if (@available(macOS 14.0, *))

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@FliegendeWurst FliegendeWurst added the 6.topic: darwin Running or building packages on Darwin label Oct 31, 2024
@khaneliman
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352623

x86_64-darwin

✅ 2 packages built:
  • fastfetch
  • fastfetch.man

aarch64-darwin

✅ 2 packages built:
  • fastfetch
  • fastfetch.man

@khaneliman khaneliman changed the title fastfetch: switch to apple-sdk_11 fastfetch: switch to apple-sdk_15 Oct 31, 2024
@khaneliman
fastfetch: switch to apple-sdk_11
da69ec3
@khaneliman
fastfetch: apple-sdk_11 -> apple-sdk_15
8db6952 
Upstream uses ifdefs and @available checks for SDK features so bump to
latest SDK and set minimum.
@khaneliman
fastfetch: use versionCheckHook
bd0f990 
No longer need manual version checking test and can verify on build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luftmensch-luftmensch luftmensch-luftmensch Awaiting requested review from luftmensch-luftmensch

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 0 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khaneliman @FliegendeWurst