Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sketchybar: use the new apple-sdk #352647

Closed
wants to merge 1 commit into from
Closed

Conversation

azuwis
Copy link
Contributor

@azuwis azuwis commented Oct 31, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@azuwis
Copy link
Contributor Author

azuwis commented Oct 31, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 352647


aarch64-darwin

✅ 1 package built:
  • sketchybar

x86_64-darwin

✅ 1 package built:
  • sketchybar

@khaneliman
Copy link
Contributor

duplicate of #352620

@FliegendeWurst FliegendeWurst added the 6.topic: darwin Running or building packages on Darwin label Oct 31, 2024
@azuwis
Copy link
Contributor Author

azuwis commented Oct 31, 2024

@khaneliman I think we should add (darwinMinVersionHook "10.13"), as upstream set x86_64-apple-macos10.13 here https://github.com/FelixKratz/SketchyBar/blob/ed1684d348fc4d4319c7f9835141524c524bacb3/makefile#L36

@khaneliman
Copy link
Contributor

@khaneliman I think we should add (darwinMinVersionHook "10.13"), as upstream set x86_64-apple-macos10.13 here https://github.com/FelixKratz/SketchyBar/blob/ed1684d348fc4d4319c7f9835141524c524bacb3/makefile#L36

I updated it, I also bumped the SDK version because they have availability checks throughout the codebase for different symbols.

@azuwis
Copy link
Contributor Author

azuwis commented Nov 1, 2024

Close this one.

I wonder why ofborg did not add me as reviewer in #352620 after eval.

@azuwis azuwis closed this Nov 1, 2024
@azuwis azuwis deleted the push-ruvqxrkkzylv branch November 1, 2024 00:45
@khaneliman
Copy link
Contributor

khaneliman commented Nov 1, 2024

for some reason i can't select you as a reviewer either
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants