zed-editor: fix license generation #352654
Merged
+12
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bbigras
reviewed
Oct 31, 2024
| @@ -14,4 +14,8 @@ index 43b2f5c458..c740a3afa2 100755 | |||
| -fi | |||
There was a problem hiding this comment.
Is this line supposed to be removed?
There was a problem hiding this comment.
Yes, see the patch before this commit. I didn't change this line.
There was a problem hiding this comment.
(as to why this line is removed at all: it disables checking for a precise version of cargo-about so we can use the one provided in nixpkgs)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #352420, generating license attribution for crates used by zed-editor has been disabled because of zed-industries/zed#19971.
This PR re-enables generating license information for crates where this information is available by removing cargo-about's
--failparameter.Having license information available for almost all dependencies is better than none.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.