blueutil: use the new apple-sdk #352660
Open
blueutil: use the new apple-sdk #352660
+0
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paparodeo
reviewed
Oct 31, 2024
pkgs/by-name/bl/blueutil/package.nix
Outdated
| @@ -2,14 +2,11 @@ | |||
| lib, | |||
| stdenv, | |||
| fetchFromGitHub, | |||
| darwin, | |||
| apple-sdk, | |||
There was a problem hiding this comment.
Suggested change
| apple-sdk, |
pkgs/by-name/bl/blueutil/package.nix
Outdated
| @@ -22,8 +19,7 @@ stdenv.mkDerivation (finalAttrs: { | |||
| }; | |||
|
|
|||
| buildInputs = [ | |||
| Foundation | |||
| IOBluetooth | |||
| apple-sdk | |||
There was a problem hiding this comment.
Suggested change
| apple-sdk |
There was a problem hiding this comment.
don't need to add apple-sdk as it is part of the stdenv
There was a problem hiding this comment.
Done on the latest push.
Thanks for the explanation.
I read through https://github.com/NixOS/nixpkgs/blob/master/doc/stdenv/platform-notes.chapter.md, but didn't found this information, I think we should add this explicitly to the doc.
azuwis
force-pushed
the
push-zmuyrssyxnuu
branch
from
c62fe3b
to
3394044
Compare
paparodeo
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.