Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fish: add patch to fix $PATH for nix-darwin #352666

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Oct 31, 2024

See the comment for details. This is adapted from my nix-darwin configuration.

cc @Enzime

cc @RossComputerGuy – this is technically a breaking change, but only when a variable is set that is only set by nix-darwin, and as a nix-darwin maintainer I affirm that it is the kind of bug‐fixing breaking change that we really want; this has been a very long‐standing issue with nix-darwin and it would be sad to tell users of stable branches they have to wait 6 months for a fix.

cc @lilyball who I think uses an alternative workaround

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy
Copy link
Member Author

emilazy commented Oct 31, 2024

Moved the conditional to a more appropriate place.

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Oct 31, 2024
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants