hyprsome: init at 0.1.12 #352677
hyprsome: init at 0.1.12 #352677
Conversation
There was a problem hiding this comment.
Their own README.md says:
Alternatives
https://github.com/Duckonaut/split-monitor-workspaces leverages the plugin system, is more feature rich and seems better maintained
hyprsome: An earlier project of similar nature
Sure you don't want to add the other one? ;)
How can I check version 0.1.12 is rev = "985e1a3b03b5118c98c03983f60ea9f74775858c";?
You missed https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#commit-conventions
When adding yourself as maintainer in the same pull request, make a separate commit with the message maintainers: add . Add the commit before those making changes to the package or module. See Nixpkgs Maintainers for details.
|
|
||
| src = fetchFromGitHub { | ||
| owner = "sopa0"; | ||
| repo = "${pname}"; |
There was a problem hiding this comment.
| repo = "${pname}"; | |
| repo = "hyprsome"; |
pkgs/README.md:
Always prefer using a hardcoded string (don't use pname, for example).
|
|
||
| cargoHash = "sha256-OVtfoTcohMLBV+W0wbKtAxfnmjFGUJbs70nLts39g+U="; | ||
|
|
||
| meta = with lib; { |
There was a problem hiding this comment.
| meta = with lib; { | |
| meta = { |
with lib; is discouraged #208242
|
|
||
| meta = with lib; { | ||
| description = "Awesome-like workspaces for Hyprland"; | ||
| homepage = "https://crates.io/crates/hyprsome"; |
There was a problem hiding this comment.
I would expect a homepage has a link to the source code?
Adds hyprsome, a tool for interacting with hyprland workspaces. Up to date version of #259495 which is now stale for long.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.