Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

brave: 1.71.118 -> 1.71.121 #352736

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

r-ryantm
Copy link
Contributor

Automatic update generated by nixpkgs-update tools. This update was made based on information from passthru.updateScript.

meta.description for brave is: Privacy-oriented browser for Desktop and Laptop computers

meta.homepage for brave is: https://brave.com/

meta.changelog for brave is: https://github.com/brave/brave-browser/blob/master/CHANGELOG_DESKTOP.md#171121

Updates performed
  • Ran passthru.UpdateScript
To inspect upstream changes
Impact

Checks done


  • built on NixOS
  • The tests defined in passthru.tests, if any, passed
  • found 1.71.121 with grep in /nix/store/scicsrf7l96a74321hv16gw30ajn2b18-brave-1.71.121
  • found 1.71.121 in filename of file in /nix/store/scicsrf7l96a74321hv16gw30ajn2b18-brave-1.71.121

Rebuild report (if merged into master) (click to expand)
2 total rebuild path(s)

2 package rebuild(s)

First fifty rebuilds by attrpath

brave
Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/scicsrf7l96a74321hv16gw30ajn2b18-brave-1.71.121 \
  --option binary-caches 'https://cache.nixos.org/ https://nix-community.cachix.org/' \
  --option trusted-public-keys '
  nix-community.cachix.org-1:mB9FSh9qf2dCimDSUo8Zy7bkq5CX+/rkCWyvRCYg3Fs=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(The Cachix cache is only trusted for this store-path realization.)
For the Cachix download to work, your user must be in the trusted-users list or you can use sudo since root is effectively trusted.

Or, build yourself:

nix-build -A brave https://github.com/r-ryantm/nixpkgs/archive/ab77e629960585dd61b61fd6e696b261c639ead2.tar.gz

Or:

nix build github:r-ryantm/nixpkgs/ab77e629960585dd61b61fd6e696b261c639ead2#brave

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/scicsrf7l96a74321hv16gw30ajn2b18-brave-1.71.121
ls -la /nix/store/scicsrf7l96a74321hv16gw30ajn2b18-brave-1.71.121/bin


Pre-merge build results

We have automatically built all packages that will get rebuilt due to
this change.

This gives evidence on whether the upgrade will break dependent packages.
Note sometimes packages show up as failed to build independent of the
change, simply because they are already broken on the target branch.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review


x86_64-linux

✅ 1 package built:
  • brave

Maintainer pings

cc @uskudnik @rht @JeffLabonte @nasirhm @buckley310 for testing.

Tip

As a maintainer, if your package is located under pkgs/by-name/*, you can comment @NixOS/nixpkgs-merge-bot merge to automatically merge this update using the nixpkgs-merge-bot.


Add a 👍 reaction to pull requests you find important.

@buckley310
Copy link
Contributor

LGTM. Tested web browsing with it.

@NixOS/nixpkgs-merge-bot merge

@nixpkgs-merge-bot
Copy link
Contributor

One or more checks are still pending, please retry after they are done. darwin checks can be ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants