apptainer, singularity: deprecate workarounds for vendorHash overriding #352756
+27
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove obsolete overriding workarounds for vendorHash, deleteVendor and proxyVendor (through the <pkg>.override interface). The workaround functionality has been fixed by commit eed069a ("buildGoModule: fix overrideAttrs overriding"), and these arguments can now be overridden using <pkg>.overrideAttrs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove obsolete overriding workarounds for vendorHash, deleteVendor, and proxyVendor (through the .override interface).
The workaround functionality has been fixed by commit eed069a ("buildGoModule: fix overrideAttrs overriding"), and these arguments can now be overridden using .overrideAttrs. This PR guides users to the now-fixed overriding approaches by warning them against the workaround. The obsolete workaround will be removed entirely after the branch-off of Nixpkgs 24.11.
Cc: @GaetanLepage, @jbedo, @SomeoneSerge
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.