Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grpc: create multi-output derivation #352757

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hbdch
Copy link

@hbdch hbdch commented Nov 1, 2024

This PR makes grpc into a multi-output derivation to reduce runtime closure size. The "dev" grpc-dev output contains the header files, pkg-config files, and CMake files. The "out" grpc output will contain the libraries, binaries, and root certificates file.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This PR makes grpc into a multi-output derivation to reduce runtime
closure size. The "dev" grpc-dev output contains the header files, pkg-config
files, and CMake files. The "out" grpc output will contain the
libraries, binaries, and root certificates file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants