kanidm: 1.3.3 -> 1.4.0 #352773
Merged
kanidm: 1.3.3 -> 1.4.0 #352773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mweinelt
force-pushed
the
kanidm-1.4.0
branch
from
0874c14
to
ff11116
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mweinelt
force-pushed
the
kanidm-1.4.0
branch
from
ea8614a
to
9308348
Compare
adamcstephens
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
looks good on x86 minus the @oddlama patch, which is breaking that test case.
/nix/store/vs3glzwyx0wbxf5q7bk5zij79xcc45ni-vm-test-run-kanidm
Already on it, will submit a separate PR soon |
|
Feel free to ping me for review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/kanidm/kanidm/releases/tag/v1.4.0
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.