Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Page h1 focusability #1428

Merged
merged 4 commits into from
Jul 21, 2023
Merged

🔧 Page h1 focusability #1428

merged 4 commits into from
Jul 21, 2023

Conversation

tesk9
Copy link
Contributor

@tesk9 tesk9 commented Jul 20, 2023

Context

Fixes A11-3182

🖼️ What does this change look like?

image

Component completion checklist

  • I've gone through the relevant sections of the Development Accessibility guide with the changes I made to this component in mind
  • Changes are clearly documented
    • Component docs include a changelog
    • Any new exposed functions or properties have docs
  • Changes extend to the Component Catalog
    • The Component Catalog is updated to use the newest version, if appropriate
    • The Component Catalog example version number is updated, if appropriate
    • Any new customizations are available from the Component Catalog
    • The component example still has:
      • an accurate preview
      • valid sample code
      • correct keyboard behavior
      • correct and comprehensive guidance around how to use the component
  • Changes to the component are tested/the new version of the component is tested
  • Component API follows standard patterns in noredink-ui
    • e.g., as a dev, I can conveniently add an nriDescription
    • and adding a new feature to the component will not require major API changes to the component

@tesk9 tesk9 added the page label Jul 20, 2023
@linear
Copy link

linear bot commented Jul 20, 2023

A11-3182 Update Nri.Ui.Page to add an ID and tabindex="-1" to the H1

https://noredink-ui.netlify.app/#/doodad/Page

Purpose: In case we use this in a SPA and someone needs to move focus to the heading, as we've instructed them to do in the ATNC guide

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 root//:elm_format_diffs has suggestions for 1 file.

To fix, run script/buck2 run //:diff_to_comment -- --fix root//:elm_format_diffs in your local checkout or apply the attached suggestions!

Have a very stylish day!

src/Nri/Ui/Page/V3.elm Outdated Show resolved Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@tesk9 tesk9 merged commit feadc47 into master Jul 21, 2023
8 checks passed
@tesk9 tesk9 deleted the bat/page-header-focusability branch July 21, 2023 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants