Merge pull request #10 from NoahStolk/implement-Triangle2D-struct · NoahStolk/detach@82ebbff

Triggered via push June 19, 2024 12:01

NoahStolk

main

Status Success

Total duration 41s

Artifacts –

push.yml

on: push

12 warnings

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-dotnet@v1, actions/checkout@v2. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/setup-dotnet@v1, actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

build: src/Detach/Collisions/Geometry3D.cs#L1014

Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)

build: src/Detach/Inline.cs#L157

Change return type to 'void'; not a single caller uses the returned value. (https://rules.sonarsource.com/csharp/RSPEC-3241)

build: src/Detach/Inline.cs#L170

Change return type to 'void'; not a single caller uses the returned value. (https://rules.sonarsource.com/csharp/RSPEC-3241)

build: src/Detach/Parsers/Sound/SoundData.cs#L6

Properties should not return arrays (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1819)

build: src/Detach/Parsers/Texture/TextureData.cs#L6

Properties should not return arrays (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1819)

build: src/Detach/Collisions/Geometry2D.cs#L83

Do not check floating point equality with exact values, use a range instead. (https://rules.sonarsource.com/csharp/RSPEC-1244)

build: src/Detach/Collisions/Geometry2D.cs#L84

Do not check floating point equality with exact values, use a range instead. (https://rules.sonarsource.com/csharp/RSPEC-1244)

build: src/Detach/Collisions/Geometry2D.cs#L117

Do not check floating point inequality with exact values, use a range instead. (https://rules.sonarsource.com/csharp/RSPEC-1244)

build: src/Detach/Collisions/Geometry2D.cs#L118

Do not check floating point inequality with exact values, use a range instead. (https://rules.sonarsource.com/csharp/RSPEC-1244)

build: src/Detach/Collisions/Primitives3D/Obb.cs#L60

Use properties where appropriate (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1024)