feat: improve i18n #347
Merged
feat: improve i18n #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Draft until NodeSecure/i18n#124 merged & releaed |
Related to NodeSecure/i18n#114 I guess ? |
fraxken
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #310 (it does not fixes it completely).
Missing i18n in the UI:
flags & warnings probably needs a
@nodesecure/i18nnew API that exports all translation. Do you agree ?Missing i18n in the CLI:
As discussed in the issue, it might be a good opportunity to build our own package in TopCli that support translations. WDYT?
Note
Also updated dependencies & GHAs