-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #25445: Document the 8.2 windows variable changes #1047
base: branches/rudder/8.2
Are you sure you want to change the base?
Fixes #25445: Document the 8.2 windows variable changes #1047
Conversation
Commit modified |
e823a2b
to
86972e4
Compare
Fixes #25445: Document the 8.2 windows variable changes
PR updated with a new commit |
|
||
=== API tokens | ||
The hook can still be deactivated by commenting its content if needed, with the risk of deploying potentially |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can just set -x
it, too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is that gonna disable the hook ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
only executable hooks are executed by rudder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry, I wasn't not clear: I meant to say "you can just remove the executable flag on the hook with chmod -x", and mixed things up
https://issues.rudder.io/issues/25445