Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #25445: Document the 8.2 windows variable changes #1047

Open
wants to merge 2 commits into
base: branches/rudder/8.2
Choose a base branch
from

Conversation

Fdall
Copy link
Contributor

@Fdall Fdall commented Sep 11, 2024

@Fdall Fdall requested a review from fanf September 11, 2024 13:10
@Fdall
Copy link
Contributor Author

Fdall commented Sep 11, 2024

Commit modified

@Fdall Fdall force-pushed the ust_25445/document_the_8_2_windows_variable_changes branch from e823a2b to 86972e4 Compare September 11, 2024 13:11
Fixes #25445: Document the 8.2 windows variable changes
@Fdall
Copy link
Contributor Author

Fdall commented Sep 11, 2024

PR updated with a new commit


=== API tokens
The hook can still be deactivated by commenting its content if needed, with the risk of deploying potentially
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just set -x it, too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is that gonna disable the hook ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only executable hooks are executed by rudder

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, I wasn't not clear: I meant to say "you can just remove the executable flag on the hook with chmod -x", and mixed things up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants