Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_due_list_aging_comment: Migration to 16.0 #633

Merged
merged 10 commits into from
Oct 11, 2023
Merged

[16.0][MIG] account_due_list_aging_comment: Migration to 16.0 #633

merged 10 commits into from
Oct 11, 2023

Conversation

RodrigoBM
Copy link

@RodrigoBM RodrigoBM changed the title 16.0 mig account due list aging comment [16.0][MIG] account_due_list_aging_comment: Migration to 16.0 May 25, 2023
@RodrigoBM RodrigoBM mentioned this pull request May 25, 2023
Open
14 tasks
Gelo-fl
Gelo-fl approved these changes May 29, 2023
View reviewed changes
Copy link

@Gelo-fl Gelo-fl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional revision OK

@JavierIniesta
Copy link

Hi @RodrigoBM
Please could you take into account this step from the migration wiki? (https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0)

@RodrigoBM RodrigoBM force-pushed the 16.0-mig-account_due_list_aging_comment branch from 989a6cd to 1ac0b6c Compare June 22, 2023 10:23
@RodrigoBM
Copy link
Author

Hi @RodrigoBM Please could you take into account this step from the migration wiki? (https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-16.0)

Done

JavierIniesta
JavierIniesta approved these changes Jun 22, 2023
View reviewed changes
Copy link

@JavierIniesta JavierIniesta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review: LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@RodrigoBM
Copy link
Author

can @bizzappdev review it?

SirAionTech
SirAionTech approved these changes Sep 27, 2023
View reviewed changes
Copy link

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I have only done a code review and checked the commit history, looks good to me

MiquelRForgeFlow and others added 10 commits September 27, 2023 18:38
@MiquelRForgeFlow @RodrigoBM
[RENAME] Renamed to account_due_list_aging_comment
83e7218 
[UPD] Update account_due_list_aging_comment.pot
@rschnapka @RodrigoBM
Translated using Weblate (German)
7aca1d8 
Currently translated at 100,0% (2 of 2 strings)

Translation: account-payment-11.0/account-payment-11.0-account_due_list_aging_comment
Translate-URL: https://translation.odoo-community.org/projects/account-payment-11-0/account-payment-11-0-account_due_list_aging_comment/de/
@cor9003 @RodrigoBM
[MIG] account_due_list_aging_comment: Migration to 12.0
641b14f 
[UPD] README.rst

[UPD] Update account_due_list_aging_comment.pot
@pedrocs-exo @RodrigoBM
Added translation using Weblate (Portuguese)
5184d64
@RodrigoBM
Translated using Weblate (Portuguese (Brazil))
5ffb2e6 
Currently translated at 100.0% (2 of 2 strings)

Translation: account-payment-12.0/account-payment-12.0-account_due_list_aging_comment
Translate-URL: https://translation.odoo-community.org/projects/account-payment-12-0/account-payment-12-0-account_due_list_aging_comment/pt_BR/

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-payment-12.0/account-payment-12.0-account_due_list_aging_comment
Translate-URL: https://translation.odoo-community.org/projects/account-payment-12-0/account-payment-12-0-account_due_list_aging_comment/
@sysadminmatmoz @RodrigoBM
Translated using Weblate (Slovenian)
8d7fc95 
Currently translated at 100.0% (2 of 2 strings)

Translation: account-payment-12.0/account-payment-12.0-account_due_list_aging_comment
Translate-URL: https://translation.odoo-community.org/projects/account-payment-12-0/account-payment-12-0-account_due_list_aging_comment/sl/
@omar7r @RodrigoBM
[MIG] account_due_list_aging_comment: Migration to 14.0
d666bfe
@ibuioli @RodrigoBM
Added translation using Weblate (Spanish (Argentina))
4984c36
@RodrigoBM
[IMP] account_due_list_aging_comment: pre-commit stuff
729efd7
@RodrigoBM
[MIG] account_due_list_aging_comment: Migration to 16.0
f2cccd9
@RodrigoBM RodrigoBM force-pushed the 16.0-mig-account_due_list_aging_comment branch from 1ac0b6c to f2cccd9 Compare September 27, 2023 16:40
@RodrigoBM
Copy link
Author

add rebase 16.0

@SirAionTech
Copy link

@OCA/banking-maintainers this has 3 reviews and is ready to merge , can someone please merge? Thanks!

@RodrigoBM
Copy link
Author

@pedrobaeza can you merge it?

@pedrobaeza pedrobaeza added this to the 16.0 milestone Oct 11, 2023
@pedrobaeza
Copy link
Member

Merging based on existing reviews:

/ocabot merge nobump
/ocabot migration account_due_list_aging_comment

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-633-by-pedrobaeza-bump-nobump, awaiting test results.

@RodrigoBM
Copy link
Author

Merging based on existing reviews:

/ocabot merge nobump /ocabot migration account_due_list_aging_comment

Thanks @pedrobaeza

@OCA-git-bot OCA-git-bot merged commit 056b01e into OCA:16.0 Oct 11, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2249b87. Thanks a lot for contributing to OCA. ❤️

@RodrigoBM RodrigoBM deleted the 16.0-mig-account_due_list_aging_comment branch October 11, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JavierIniesta JavierIniesta JavierIniesta approved these changes

@Gelo-fl Gelo-fl Gelo-fl approved these changes

@SirAionTech SirAionTech SirAionTech approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.