Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.0 mig-account_payment_notification #660

Merged
merged 7 commits into from
Aug 11, 2023

Conversation

anddago78
Copy link

This module lets you notify partners about sent payment or debit orders.

You can do that by e-mail and/or by SMS. It is automated by default.

MT-3084 @moduon @Shide @rafaelbn @fcvalgar please reviews :)

yajo and others added 7 commits June 6, 2023 13:42
This module lets you notify partners about sent payment or debit orders.

You can do that by e-mail and/or by SMS. It is automated by default.

@moduon MT-1232
Before this patch, generated emails didn't produce notification records. Thus, the message didn't display sent status.

Instead of mass mailing, we use now the mass post system. This way, notifications appear as usual.

Some tests added to ensure this behavior persists.

@moduon MT-1232
Copy link

@fcvalgar fcvalgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review.
LGTM, thank you @anddago78

image

Copy link
Member

@rafaelbn rafaelbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼 Maybe we could improve a little bit templates

@fcvalgar will check again and after we decide

This migration is 👍🏼 exactly like v15


.. |maintainer-yajo| image:: https://github.com/yajo.png?size=40px
:target: https://github.com/yajo
:alt: yajo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anddago78 add mysel here please

:target: github.com/rafaelbn
:alt: rafaelbn

Thanks

@rafaelbn
Copy link
Member

rafaelbn commented Aug 9, 2023

@yajo ready to merge!

@rafaelbn
Copy link
Member

Please @OCA/banking-maintainers could you please merge? This is a v16 migration we are using un PRODUCTION already for serveral months in 16 and sin 2022 en 15

Thank you! 😄

@JordiBForgeFlow
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-660-by-JordiBForgeFlow-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 125ec61 into OCA:16.0 Aug 11, 2023
5 of 6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 2ebfb6c. Thanks a lot for contributing to OCA. ❤️

@yajo yajo deleted the 16.0-mig-account_payment_notification branch August 21, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants