-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16.0 mig-account_payment_notification #660
16.0 mig-account_payment_notification #660
Conversation
This module lets you notify partners about sent payment or debit orders. You can do that by e-mail and/or by SMS. It is automated by default. @moduon MT-1232
Before this patch, generated emails didn't produce notification records. Thus, the message didn't display sent status. Instead of mass mailing, we use now the mass post system. This way, notifications appear as usual. Some tests added to ensure this behavior persists. @moduon MT-1232
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional review.
LGTM, thank you @anddago78
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼 Maybe we could improve a little bit templates
@fcvalgar will check again and after we decide
This migration is 👍🏼 exactly like v15
|
||
.. |maintainer-yajo| image:: https://github.com/yajo.png?size=40px | ||
:target: https://github.com/yajo | ||
:alt: yajo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yajo ready to merge! |
Please @OCA/banking-maintainers could you please merge? This is a v16 migration we are using un PRODUCTION already for serveral months in 16 and sin 2022 en 15 Thank you! 😄 |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 2ebfb6c. Thanks a lot for contributing to OCA. ❤️ |
This module lets you notify partners about sent payment or debit orders.
You can do that by e-mail and/or by SMS. It is automated by default.
MT-3084 @moduon @Shide @rafaelbn @fcvalgar please reviews :)