Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] account_payment_register_keep_amount #665

Merged

Conversation

SirTakobi
Copy link
Contributor

No description provided.

@SirTakobi SirTakobi force-pushed the 14.0-add-account_payment_register_keep_amount branch 2 times, most recently from 503edaf to 2fb32cc Compare August 17, 2023 13:33
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@matteoopenf
Copy link

@pedrobaeza is it possibile to merge?
thank you so much

@pedrobaeza pedrobaeza added this to the 14.0 milestone Sep 27, 2023
"summary": "Keep set amount during Payment registration.",
"version": "14.0.1.0.0",
"category": "Account-payment",
"website": "https://github.com/OCA/account-payment"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Website should be the base one.

@@ -0,0 +1,3 @@
Allow to keep the set amount in Payment registration wizard when Journal is changed.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Allow to keep the set amount in Payment registration wizard when Journal is changed.
Allow to keep the amount set in the payment registration wizard when the journal is changed.

@matteoopenf
Copy link

@SirAionTech @SimoRubi can you do the fix?
thank you

@SirAionTech
Copy link

@SirAionTech @SimoRubi can you do the fix?
thank you

I won't be working on this module in the near future; if there is work to do anybody can supersede this pull request and do it.
Please just keep the authorship of the work that has been done

@pedrobaeza
Copy link
Member

OK, my comments are not critical, so let's merge it:

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-665-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3b9e7af into OCA:14.0 Sep 27, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

@pedrobaeza The merge process could not be finalized because an exception was raised: <class 'requests.exceptions.ConnectionError'>: A connection-level exception occurred: ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response')).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants