-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
16.0 mig account payment batch process #690
Conversation
Currently translated at 100.0% (46 of 46 strings) Translation: account-payment-15.0/account-payment-15.0-account_payment_batch_process Translate-URL: https://translation.odoo-community.org/projects/account-payment-15-0/account-payment-15-0-account_payment_batch_process/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-payment-15.0/account-payment-15.0-account_payment_batch_process Translate-URL: https://translation.odoo-community.org/projects/account-payment-15-0/account-payment-15-0-account_payment_batch_process/
Hi @pedrobaeza , I would like to understand why @noharr 's PR is rejected about code coverage, whereas the version 15.0 of this module were merged without any tests here: #539 We will try to add some tests to increase coverage but was there a special treatment about version 15.0? Thanks for your help! |
It's not rejected. It's simply that the code coverage has lowered applying with this PR. It's a quality metric, but it's not enforced for merging modules. The other metrics should be green though. Check https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/oca_module_lifecycle_development_status.rst for information about the requirements. |
I'm rather troubled that we have a payment related module in the OCA without any unit test. #564 has a serious issue that would not have gone unnoticed otherwise. Would you consider to add the tests in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pr looks good but tests would be nice indeed.
Hey there, I added a test over in #716 to move this forward. |
Superseded by #716 |
No description provided.