Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16.0 mig account payment batch process #690

Closed
wants to merge 17 commits into from

Conversation

noharr
Copy link

@noharr noharr commented Dec 15, 2023

No description provided.

@isabellerichard
Copy link
Member

Hi @pedrobaeza , I would like to understand why @noharr 's PR is rejected about code coverage, whereas the version 15.0 of this module were merged without any tests here: #539

We will try to add some tests to increase coverage but was there a special treatment about version 15.0?

Thanks for your help!

@pedrobaeza
Copy link
Member

It's not rejected. It's simply that the code coverage has lowered applying with this PR. It's a quality metric, but it's not enforced for merging modules. The other metrics should be green though. Check https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/oca_module_lifecycle_development_status.rst for information about the requirements.

@metaminux
Copy link

Hi everyone,

#564 is already approved for migrating account_payment_batch_process and none of them are listed in #546

Can someone with sufficient rights helps to mutualize the efforts ?

@StefanRijnhart
Copy link
Member

I'm rather troubled that we have a payment related module in the OCA without any unit test. #564 has a serious issue that would not have gone unnoticed otherwise. Would you consider to add the tests in this PR?

Copy link

@robinkeunen robinkeunen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pr looks good but tests would be nice indeed.

@robinkeunen
Copy link

Hey there, I added a test over in #716 to move this forward.

@JordiBForgeFlow
Copy link
Member

Superseded by #716

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.