Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] account_payment_term_partner_holiday: Migration to 16.0 #744

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from
Open

[16.0][MIG] account_payment_term_partner_holiday: Migration to 16.0 #744

wants to merge 1 commit into from

Conversation

PabloCatalinaCastello
Copy link

@PabloCatalinaCastello PabloCatalinaCastello commented Jul 2, 2024 •
edited
Loading

@PabloCatalinaCastello PabloCatalinaCastello changed the title 16.0 mig account payment term partner holiday [16.0] [MIG] account payment term partner holiday Jul 4, 2024
@PabloCatalinaCastello PabloCatalinaCastello force-pushed the 16.0-mig-account_payment_term_partner_holiday branch 4 times, most recently from 8fbceee to a9f86cb Compare July 10, 2024 06:44
alvaro-domatix
alvaro-domatix suggested changes Jul 12, 2024
View reviewed changes
account_payment_term_partner_holiday/models/account_move.py Outdated
"""Inject a context for getting the partner when computing payment term."""
for move in self:
super(
AccountMove, self.with_context(move_partner_id=move.partner_id.id)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If self is being iterated the super should be done for "move.with_context(..." not "self.with_context(..."

@PabloCatalinaCastello PabloCatalinaCastello force-pushed the 16.0-mig-account_payment_term_partner_holiday branch from dcb282e to 423671b Compare July 12, 2024 10:25
@alvaro-domatix
Copy link

Hi @pedrobaeza , could you please take a look at this PR when you have a chance? Thanks!

@pedrobaeza pedrobaeza changed the title [16.0] [MIG] account payment term partner holiday [16.0] [MIG] account_payment_term_partner_holiday Jul 29, 2024
@pedrobaeza pedrobaeza changed the title [16.0] [MIG] account_payment_term_partner_holiday [16.0][MIG] account_payment_term_partner_holiday: Migration to 16.0 Jul 29, 2024
@pedrobaeza
Copy link
Member

Sorry, not using this module.

/ocabot migration account_payment_term_partner_holiday

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 29, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jul 29, 2024
Open
14 tasks
@alvaro-domatix
Copy link

Sorry for being curious, but can I ask why? Is it just a coincidence, or is there another reason?

Thanks Pedro!

@pedrobaeza
Copy link
Member

We don't have customers with this need for now. I also personally think that a payment debt shouldn't be delayed because the debtor is on holidays. It's the payer problem. If you go on holiday, program the payments.

nachoserra-domatix
nachoserra-domatix approved these changes Aug 9, 2024
View reviewed changes
Copy link

@nachoserra-domatix nachoserra-domatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@Gerloav
Copy link

Gerloav commented Aug 9, 2024

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nachoserra-domatix nachoserra-domatix nachoserra-domatix approved these changes

@alvaro-domatix alvaro-domatix alvaro-domatix approved these changes

Assignees
No one assigned
Labels
approved ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.
6 participants
@PabloCatalinaCastello @alvaro-domatix @pedrobaeza @OCA-git-bot @Gerloav @nachoserra-domatix