Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_payment_return: Fix line_ids display on form view #749

Merged

Conversation

sergiobstoj
Copy link
Member

@sergiobstoj sergiobstoj commented Jul 17, 2024

Fix on line_ids field in form view. This is because when adding lines, the disposition of the table is wrong:
image

With these changes, the disposition is correct:
image

@sergiobstoj sergiobstoj changed the title [FIX] account_payment_return: Fix line_ids display on form view [16.0][FIX] account_payment_return: Fix line_ids display on form view Jul 17, 2024
@sergiobstoj sergiobstoj marked this pull request as ready for review July 22, 2024 13:01
Copy link

@PabloMartFL PabloMartFL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional Review LGTM!, The chart is correclty displayed when you create a new return or when you are trying to modify it

https://www.awesomescreenshot.com/video/29774284?key=3117237bfbd0a787b6417cce900a3b0c

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please fw-port it to v17 if applicable?

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-749-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 13c3e13 into OCA:16.0 Jul 25, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 038933f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants