Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] account_payment_return: don't copy some fields #757

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

carlos-lopez-tecnativa
Copy link

If an invoice with the returned_payment field set is duplicated, the new invoice will incorrectly have this field activated. This fix prevents that from happening. same case for field move_id on payment.return

Partial backport of #752 according comment #752 (review)

@Tecnativa TT49281

@pedrobaeza @carolinafernandez-tecnativa could you review please

If an invoice with the returned_payment field set is duplicated, the new invoice will incorrectly have this field activated. This fix prevents that from happening.
same case for field move_id on payment.return
@pedrobaeza pedrobaeza added this to the 16.0 milestone Aug 9, 2024
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-757-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit c8adb79 into OCA:16.0 Aug 9, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 131833c. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 16.0-account_payment_return-copy branch August 9, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants