[16.0][FIX] account_payment_term_extension: Add cash_rounding parameter to _compute_terms() to prevent error

[victoralmau]

Add cash_rounding parameter to _compute_terms() to prevent error

Required since odoo/odoo@84b03f7

Please @pedrobaeza can you review it?

@Tecnativa

[pedrobaeza]

This module seems a bit bloated and copying/pasting a lot of code from upstream, while the feature it brings don't require it directly. Can't this be rethought for not requiring this doing some kind of tricks?

[victoralmau]

I agree that currently the _compute_terms() method copies a lot of code and probably can be refactored but, is it the time now? I think not, what is necessary now is to unblock those who use this module and then, create a new PR to refactor this if possible (probably it will be necessary to create extra methods in odoo core).

[pedrobaeza]

Then just add the parameter, and issue an error if the parameter is used, adding in the ROADMAP that this module is not compatible with cash rounding.

[pedrobaeza]

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-758-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 3427a63. Thanks a lot for contributing to OCA. ❤️