-
-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][FIX] account_payment_term_extension: Add cash_rounding parameter to _compute_terms() to prevent error #758
Conversation
7544e4e
to
8e580ff
Compare
This module seems a bit bloated and copying/pasting a lot of code from upstream, while the feature it brings don't require it directly. Can't this be rethought for not requiring this doing some kind of tricks? |
I agree that currently the |
Then just add the parameter, and issue an error if the parameter is used, adding in the ROADMAP that this module is not compatible with cash rounding. |
…_compute_terms() to prevent error Required since odoo/odoo@84b03f7
8e580ff
to
4fee4cc
Compare
/ocabot merge patch |
Hey, thanks for contributing! Proceeding to merge this for you. |
Congratulations, your PR was merged at 3427a63. Thanks a lot for contributing to OCA. ❤️ |
Add cash_rounding parameter to
_compute_terms()
to prevent errorRequired since odoo/odoo@84b03f7
Please @pedrobaeza can you review it?
@Tecnativa