-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] base_bank_from_iban: automatically create banks with schwifty #170
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
/ocabot merge major |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at d1728b4. Thanks a lot for contributing to OCA. ❤️ |
@pedrobaeza @carlosdauden @len-foss @Abranes Hey, |
Indeed, I wasn't aware, but I'm afraid now that this can't be changed. |
the branch is protected and force cannot be used? |
Doing that will screw all the people that have already pulled this branch, forcing them to do a reset, so that's too much to do, and more having passed several weeks since the merge. |
And a rebert and then commit again with the correct message? |
A more convoluted history... Let's fix this in v17. At the end, the commit is linked to this PR, where there is enough information. |
Using Schwifty, we can automatically get bank information from a valid IBAN, i.e. BIC, Swift, code, and bank name.
This quick POC automatically create banks at creation/write of a bank account.
In practice the current code might be annoying if used on a DB where banks have already been created with incomplete information. I don't have have any relevant experience with that so I'd be interested to know the best approach to that issue. If used on a new DB, it should just simplify neatly the encoding process.
This could also go into an overriding module.
https://schwifty.readthedocs.io/en/latest